v5 Updates #29
Merged
v5 Updates #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
smithamax
commented
Feb 13, 2025
smithamax
commented
- use native fetch
- better network errors
- drop support for old load/ipc_manifest
- typescript everything
- update build tools
- use native fetch - better network errors - drop support for old load/ipc_manifest - typescript everything - update build tools
denwilliams
reviewed
Feb 20, 2025
| "esModuleInterop": true, | ||
| "typeRoots": ["./node_modules/@types", "./types"] | ||
| } | ||
| "extends": ["@tsconfig/node20/tsconfig"] |
Comment on lines
-49
to
+46
| "@loke/context": "^0.0.1", | ||
| "find-up": "^1.1.2", | ||
| "got": "^6.3.0", | ||
| "node-abort-controller": "^3.0.1", | ||
| "node-fetch": "2.6.7", | ||
| "p-finally": "^1.0.0" | ||
| "@loke/context": "^0.0.1" |
There was a problem hiding this comment.
Nice, almost 0 deps.
is it worth having @loke/context as a peer dep?
Or it is small enough to not worry.
There was a problem hiding this comment.
It might need to be a peer dep, but for for now there is only one version so can deal with that when its an issue
Comment on lines
-51
to
-53
| "got": "^6.3.0", | ||
| "node-abort-controller": "^3.0.1", | ||
| "node-fetch": "2.6.7", |
There was a problem hiding this comment.
We had got and node-fetch?
There was a problem hiding this comment.
the "legacy" client used got, newer one used node-fetch
denwilliams
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.